[OpenVerse] Bug

[Andy Goth <unununium@openverse.org>]

[MODERATORS NOTE: BUG FIXED, GET A NEW CLIENT FROM THE CVS FOR THE FIX.]

I found a bug in the client.  It will accept non-numeric values for PUSH
and maybe MOVE.  My server code accidentally sent "x" and "y" (forgot the
$'s), as is shown by the first two lines of this cutout of my server log.

(sock4) <-- PUSH x y 20
(sock4) <-- MOVE Unununium x y 20
(sock4) <-- PING
(sock4) --> DCCSENDROOM gothchess.gif
(sock4) --- Already getting gothchess.gif
(sock4) --> MOVE Unununium x y 20
(sock4) --> PONG
(sock4) <-> Disconnected! 127.0.0.1:1654
(!) --- SOCKET_CLOSE sock4

[andy@localhost .OpenVerse]$ ./gothchess.tcl pserver.cfg 
------------ Loading Config File -----------
(!) --- SOCKET_OPEN sock3
(sock4) <-> New Connection! 127.0.0.1:1655
(?) --> AUTH Unununium x y default.gif -4 36 1988 10 -16
(sock4) <-- AUTH FAILED (Non Numeric)
(sock4) <-> Disconnected! 127.0.0.1:1655
(!) --- SOCKET_CLOSE sock4


Then I killed and restarted the server (see?).  I next attempted to
reconnect, but the server kicked the client because it was attempting to
connect at location "x", "y".  The server is careful about numeric values,
but the client doesn't watch out for a faulty server.  It appears to trust
that it never goofs.

I believe Cruise corrected a variant of this bug in the object code so that
the server can't send bogus objects with, say, a duration of "moo".

  __   _  _ __ _   _    __   _  ___ _  _
  /_\  |\ | | \ \ /    / __ / \  |  |__|
 /   \ | \| |_/  |     \__| \_/  |  |  |
unununium@openverse.org  zap.to/andygoth/
 andygoth@ectisp.net         35256413
-----------------------------------------
  Please sign the Linux Driver Petition!
 <http://www.libranet.com/petition.html>
-------------------------------------------------------

-- 
Cruise - 
OpenVerse Visual Chat - http://openverse.org/
-------------------------------------------------------

-- 
Cruise - 
OpenVerse Visual Chat - http://openverse.org/
-----------------------------------------------------------------
To unsubscribe to the OpenVerse mailing list send a message
to openverse-request@openverse.org with the following word
in the BODY of the message.

UNSUBSCRIBE

If you need assistance from a human, email cruise@openverse.org
-----------------------------------------------------------------